linux-kernel - Re: [PATCH 03/13] dt-bindings: soc/microchip: update sys ctrlr compat string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63e29e99-d064-b157-eabc-ff08f55eef72@microchip.com>
Date:   Tue, 30 Nov 2021 08:35:34 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <robh@...nel.org>
CC:     <linus.walleij@...aro.org>, <bgolaszewski@...libre.com>,
        <jassisinghbrar@...il.com>, <paul.walmsley@...ive.com>,
        <palmer@...belt.com>, <aou@...s.berkeley.edu>,
        <a.zummo@...ertech.it>, <alexandre.belloni@...tlin.com>,
        <broonie@...nel.org>, <gregkh@...uxfoundation.org>,
        <Lewis.Hanly@...rochip.com>, <Daire.McNamara@...rochip.com>,
        <atish.patra@....com>, <Ivan.Griffin@...rochip.com>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-crypto@...r.kernel.org>,
        <linux-rtc@...r.kernel.org>, <linux-spi@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <krzysztof.kozlowski@...onical.com>,
        <geert@...ux-m68k.org>, <bin.meng@...driver.com>
Subject: Re: [PATCH 03/13] dt-bindings: soc/microchip: update sys ctrlr compat
 string

On 29/11/2021 20:03, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Nov 08, 2021 at 03:05:44PM +0000, conor.dooley@...rochip.com wrote:
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> Update 'compatible' strings for system controller drivers to the
>> approved Microchip name.
> 
> Why do I care what Microchip approved? You all picked identifiers
> (that's all it is) and now get to live with them.
Hi Rob,

You're speaking to the person who was perfectly happy with 
"polarfire-soc" when I wrote the binding last year, but I was asked to 
change it in order avoid having a different compatible string in the 
device tree for the soc and in the binding for a device that only exists 
in that soc.

If the v2 was a complete rename from "polarfire-soc-*" to "mpfs-*", 
including the file name - as opposed to an addition and I changed the 
commit message to the following would you be happier with the patch?

 > Change "polarfire-soc-*" compatible strings to "mpfs-*" in its system
 > controller bindings in order to match the compatible string used in
 > the soc binding and device tree.

Thanks,
Conor.

> 
>>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>>   .../bindings/mailbox/microchip,polarfire-soc-mailbox.yaml     | 4 +++-
>>   .../soc/microchip/microchip,polarfire-soc-sys-controller.yaml | 4 +++-
>>   drivers/mailbox/mailbox-mpfs.c                                | 1 +
>>   3 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml
>> index bbb173ea483c..b08c8a158eea 100644
>> --- a/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>>
>>   properties:
>>     compatible:
>> -    const: microchip,polarfire-soc-mailbox
>> +    enum:
>> +      - microchip,polarfire-soc-mailbox
>> +      - microchip,mpfs-mailbox
>>
>>     reg:
>>       items:
>> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
>> index 2cd3bc6bd8d6..d6c953cd154b 100644
>> --- a/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
>> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
>> @@ -19,7 +19,9 @@ properties:
>>       maxItems: 1
>>
>>     compatible:
>> -    const: microchip,polarfire-soc-sys-controller
>> +    enum:
>> +      - microchip,polarfire-soc-sys-controller
>> +      - microchip,mpfs-sys-controller
>>
>>   required:
>>     - compatible
>> diff --git a/drivers/mailbox/mailbox-mpfs.c b/drivers/mailbox/mailbox-mpfs.c
>> index 0d6e2231a2c7..9d5e558a6ee6 100644
>> --- a/drivers/mailbox/mailbox-mpfs.c
>> +++ b/drivers/mailbox/mailbox-mpfs.c
>> @@ -233,6 +233,7 @@ static int mpfs_mbox_probe(struct platform_device *pdev)
>>
>>   static const struct of_device_id mpfs_mbox_of_match[] = {
>>        {.compatible = "microchip,polarfire-soc-mailbox", },
>> +     {.compatible = "microchip,mpfs-mailbox", },
>>        {},
>>   };
>>   MODULE_DEVICE_TABLE(of, mpfs_mbox_of_match);
>> --
>> 2.33.1
>>
>>