linux-kernel - Re: [PATCH 2/7] power: supply: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211130110334.egzcne2l7mgmqjfg@earth.universe>
Date:   Tue, 30 Nov 2021 12:03:34 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Luca Weiss <luca@...tu.xyz>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] power: supply: qcom_smbb: support pm8226

Hi,

On Thu, Nov 18, 2021 at 10:02:05PM +0100, Luca Weiss wrote:
> PM8226 (used in MSM8226) has v1 smbb hardware and works fine with the
> current driver.
> 
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/qcom_smbb.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c
> index 84cc9fba029d..bd50124eef9f 100644
> --- a/drivers/power/supply/qcom_smbb.c
> +++ b/drivers/power/supply/qcom_smbb.c
> @@ -863,8 +863,8 @@ static int smbb_charger_probe(struct platform_device *pdev)
>  	}
>  
>  	chg->revision += 1;
> -	if (chg->revision != 2 && chg->revision != 3) {
> -		dev_err(&pdev->dev, "v1 hardware not supported\n");
> +	if (chg->revision != 1 && chg->revision != 2 && chg->revision != 3) {
> +		dev_err(&pdev->dev, "v%d hardware not supported\n", chg->revision);
>  		return -ENODEV;
>  	}
>  	dev_info(&pdev->dev, "Initializing SMBB rev %u", chg->revision);
> @@ -1012,6 +1012,7 @@ static int smbb_charger_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id smbb_charger_id_table[] = {
> +	{ .compatible = "qcom,pm8226-charger" },
>  	{ .compatible = "qcom,pm8941-charger" },
>  	{ }
>  };
> -- 
> 2.34.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)