linux-kernel - Re: [PATCH] mtd: dataflash: Add device-tree SPI IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211130121110.6026f788@xps13>
Date:   Tue, 30 Nov 2021 12:11:10 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] mtd: dataflash: Add device-tree SPI IDs

Hi Jon,

jonathanh@...dia.com wrote on Tue, 30 Nov 2021 08:53:08 +0000:

> Hi Miquel,
> 
> On 19/11/2021 18:33, Miquel Raynal wrote:
> > On Mon, 2021-11-15 at 11:36:55 UTC, Jon Hunter wrote:  
> >> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
> >> compatible") added a test to check that every SPI driver has a
> >> spi_device_id for each DT compatiable string defined by the driver
> >> and warns if the spi_device_id is missing. The spi_device_ids are
> >> missing for the dataflash driver and the following warnings are now
> >> seen.
> >>
> >>   WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,at45
> >>   WARNING KERN SPI driver mtd_dataflash has no spi_device_id for atmel,dataflash
> >>
> >> Fix this by adding the necessary spi_device_ids.
> >>
> >> Signed-off-by: Jon Hunter <jonathanh@...dia.com>  
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.  
> 
> 
> Please can you submit as a fix for v5.16? The commit that introduced this is already in the mainline.

Yes of course. Can you resubmit with a Fixes tag?

> 
> Thanks
> Jon
> 


Thanks,
Miquèl