linux-kernel - Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yaf6wa5tyO/oCCeK@robh.at.kernel.org>
Date:   Wed, 1 Dec 2021 16:44:17 -0600
From:   Rob Herring <robh@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>,
        Heng Sia <jee.heng.sia@...el.com>, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps
 properties

On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "snps,block-size" and "snps,priority" properties should be grouped
> using angle brackets.

For these, the tools should allow either way. Where are you seeing an 
error?

I tried to rationalize which way should be 'correct' and gave up. I 
think bracketing only makes sense for matrix and phandle+arg cases.

> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 79e241498e2532ce..90d9274e5464e396 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -120,7 +120,7 @@ examples:
>           dma-channels = <4>;
>           snps,dma-masters = <2>;
>           snps,data-width = <3>;
> -         snps,block-size = <4096 4096 4096 4096>;
> -         snps,priority = <0 1 2 3>;
> +         snps,block-size = <4096>, <4096>, <4096>, <4096>;
> +         snps,priority = <0>, <1>, <2>, <3>;
>           snps,axi-max-burst-len = <16>;
>       };
> -- 
> 2.25.1
> 
>