linux-kernel - RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK0PR06MB3202BD13E356FA86B1A5CAEE80689@HK0PR06MB3202.apcprd06.prod.outlook.com>
Date:   Wed, 1 Dec 2021 06:31:21 +0000
From:   Neal Liu <neal_liu@...eedtech.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Felipe Balbi <balbi@...nel.org>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Cai Huoqing <caihuoqing@...du.com>,
        Tao Ren <rentao.bupt@...il.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        kernel test robot <lkp@...el.com>,
        Sasha Levin <sashal@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Sent: Wednesday, December 1, 2021 2:18 PM
> To: Neal Liu <neal_liu@...eedtech.com>
> Cc: Felipe Balbi <balbi@...nel.org>; Joel Stanley <joel@....id.au>; Andrew
> Jeffery <andrew@...id.au>; Cai Huoqing <caihuoqing@...du.com>; Tao Ren
> <rentao.bupt@...il.com>; Julia Lawall <julia.lawall@...ia.fr>; kernel test
> robot <lkp@...el.com>; Sasha Levin <sashal@...nel.org>;
> linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org; BMC-SW
> <BMC-SW@...eedtech.com>
> Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
> 
> On Wed, Dec 01, 2021 at 05:43:16AM +0000, Neal Liu wrote:
> > > -----Original Message-----
> > > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Sent: Tuesday, November 30, 2021 7:45 PM
> > > To: Neal Liu <neal_liu@...eedtech.com>
> > > Cc: Felipe Balbi <balbi@...nel.org>; Joel Stanley <joel@....id.au>;
> > > Andrew Jeffery <andrew@...id.au>; Cai Huoqing
> > > <caihuoqing@...du.com>; Tao Ren <rentao.bupt@...il.com>; Julia
> > > Lawall <julia.lawall@...ia.fr>; kernel test robot <lkp@...el.com>;
> > > Sasha Levin <sashal@...nel.org>; linux-usb@...r.kernel.org;
> > > linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > > linux-aspeed@...ts.ozlabs.org; BMC-SW <BMC-SW@...eedtech.com>
> > > Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier
> > > descriptor
> > >
> > > On Tue, Nov 30, 2021 at 06:42:53PM +0800, Neal Liu wrote:
> > > > Support qualifier descriptor to pass USB30CV compliance test.
> > >
> > > Please provide more information here in this description.  This does
> > > not explain what is happening here very well.
> > >
> > > Also, what is "USB30CV"?
> > >
> >
> > USB 3 Command Verifier (USB3CV) is the official tool for USB 3 Hub and
> Device Framework testing.
> > The USB3CV tool includes the xHCI Compliance Drivers for use with the
> USB3CV.
> 
> Please put that information in the changelog text.
> 
> > We would like to pass USB3CV - Chapter 9 Test [USB 2 devices] - Device
> Qualifier Tests.
> > A high-speed capable device that has different device information for
> > full-speed and high-speed must have a Device Qualifier Descriptor.
> > This patch is to support device qualifier, and the host will retrieve it through
> Get Descriptor request.
> 
> Again, this type of information needs to go into the changelog text.
> 
> thanks,
> 
> greg k-h

Okay, I'll put it in next patch. Thanks

-Neal