linux-kernel - Re: [PATCH v4 06/24] ARM: tegra: Add common device-tree base for Tegra30 ASUS Transformers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YadJSRww8we7tzjP@qmqm.qmqm.pl>
Date:   Wed, 1 Dec 2021 11:07:05 +0100
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        David Heidelberg <david@...t.cz>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Anton Bambura <jenneron@...tonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljevic <mnidza@...look.com>,
        Ion Agorria <ion@...rria.com>,
        Ihor Didenko <tailormoon@...bler.ru>,
        Andreas Westman Dorcsak <hedmoo@...oo.com>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Raffaele Tranquillini <raffaele.tranquillini@...il.com>,
        Jasper Korten <jja2000@...il.com>,
        Thomas Graichen <thomas.graichen@...il.com>,
        Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/24] ARM: tegra: Add common device-tree base for
 Tegra30 ASUS Transformers

On Wed, Dec 01, 2021 at 01:38:02AM +0300, Dmitry Osipenko wrote:
> From: Svyatoslav Ryhel <clamor95@...il.com>
[...]
> +	i2c2: i2c@...0c400 {
> +		status = "okay";
> +		clock-frequency = <400000>;
> +	};
[...]

Nit: You could now use the new controller handles directly - that would
avoid some indentation and duplication. Though I understand it is a lot
of tedious reformatting.

Best Regards
Michał Mirosław