linux-kernel - Re: [PATCH v4 06/24] ARM: tegra: Add common device-tree base for Tegra30 ASUS Transformers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Dec 2021 17:08:21 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        David Heidelberg <david@...t.cz>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Anton Bambura <jenneron@...tonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljevic <mnidza@...look.com>,
        Ion Agorria <ion@...rria.com>,
        Ihor Didenko <tailormoon@...bler.ru>,
        Andreas Westman Dorcsak <hedmoo@...oo.com>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Raffaele Tranquillini <raffaele.tranquillini@...il.com>,
        Jasper Korten <jja2000@...il.com>,
        Thomas Graichen <thomas.graichen@...il.com>,
        Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/24] ARM: tegra: Add common device-tree base for
 Tegra30 ASUS Transformers

01.12.2021 13:07, Michał Mirosław пишет:
> On Wed, Dec 01, 2021 at 01:38:02AM +0300, Dmitry Osipenko wrote:
>> From: Svyatoslav Ryhel <clamor95@...il.com>
> [...]
>> +	i2c2: i2c@...0c400 {
>> +		status = "okay";
>> +		clock-frequency = <400000>;
>> +	};
> [...]
> 
> Nit: You could now use the new controller handles directly - that would
> avoid some indentation and duplication. Though I understand it is a lot
> of tedious reformatting.

I see that there are people who prefer to use labels everywhere.
Historically Tegra device-trees never used handles for nodes. I think
should be better to convert all DTs together to keep them consistent,
which I was asking to do before, but nobody wanted to put effort into
doing that.

There are already quite a lot of DT changes scheduled for 5.17, perhaps
better to defer the extra changes for 5.18. I will add it to my todo
list, but if you're going to type the patches, then please either send
them to me, or to ML, or create PR to grate kernel.

At some point in the past we had this common DTSI using labels for
handles, but I asked to keep the DTs consistent, so we don't have them now.