linux-kernel - Re: [PATCH v2 1/4] binder: fix handling of error during copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211201134948.iq4tcgz6r4e2tus7@wittgenstein>
Date:   Wed, 1 Dec 2021 14:49:48 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Todd Kjos <tkjos@...gle.com>
Cc:     gregkh@...uxfoundation.org, christian@...uner.io, arve@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        maco@...gle.com, joel@...lfernandes.org, kernel-team@...roid.com,
        avakj45@...il.com, Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v2 1/4] binder: fix handling of error during copy

On Tue, Nov 30, 2021 at 10:51:49AM -0800, Todd Kjos wrote:
> If a memory copy function fails to copy the whole buffer,
> a positive integar with the remaining bytes is returned.
> In binder_translate_fd_array() this can result in an fd being
> skipped due to the failed copy, but the loop continues
> processing fds since the early return condition expects a
> negative integer on error.
> 
> Fix by returning "ret > 0 ? -EINVAL : ret" to handle this case.
> 
> Fixes: bb4a2e48d510 ("binder: return errors from buffer copy functions")
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Todd Kjos <tkjos@...gle.com>
> ---

Looks good.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>