linux-kernel - Re: [PATCH v2 2/4] binder: avoid potential data leakage when copying txn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211201135442.d4r3va2q75rressv@wittgenstein>
Date:   Wed, 1 Dec 2021 14:54:42 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Todd Kjos <tkjos@...gle.com>
Cc:     gregkh@...uxfoundation.org, christian@...uner.io, arve@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        maco@...gle.com, joel@...lfernandes.org, kernel-team@...roid.com,
        avakj45@...il.com, Martijn Coenen <maco@...roid.com>
Subject: Re: [PATCH v2 2/4] binder: avoid potential data leakage when copying
 txn

On Tue, Nov 30, 2021 at 10:51:50AM -0800, Todd Kjos wrote:
> Transactions are copied from the sender to the target
> first and objects like BINDER_TYPE_PTR and BINDER_TYPE_FDA
> are then fixed up. This means there is a short period where
> the sender's version of these objects are visible to the
> target prior to the fixups.
> 
> Instead of copying all of the data first, copy data only
> after any needed fixups have been applied.
> 
> Fixes: 457b9a6f09f0 ("Staging: android: add binder driver")
> Reviewed-by: Martijn Coenen <maco@...roid.com>
> Signed-off-by: Todd Kjos <tkjos@...gle.com>
> ---

Looks good.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>