linux-kernel - Re: [PATCH v2 3/4] binder: read pre-translated fds from sender buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211201135851.tv3li4xi5s4hzeeg@wittgenstein>
Date:   Wed, 1 Dec 2021 14:58:51 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Todd Kjos <tkjos@...gle.com>
Cc:     gregkh@...uxfoundation.org, christian@...uner.io, arve@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        maco@...gle.com, joel@...lfernandes.org, kernel-team@...roid.com,
        avakj45@...il.com, Martijn Coenen <maco@...roid.com>
Subject: Re: [PATCH v2 3/4] binder: read pre-translated fds from sender buffer

On Tue, Nov 30, 2021 at 10:51:51AM -0800, Todd Kjos wrote:
> This patch is to prepare for an up coming patch where we read
> pre-translated fds from the sender buffer and translate them before
> copying them to the target.  It does not change run time.
> 
> The patch adds two new parameters to binder_translate_fd_array() to
> hold the sender buffer and sender buffer parent.  These parameters let
> us call copy_from_user() directly from the sender instead of using
> binder_alloc_copy_from_buffer() to copy from the target.  Also the patch
> adds some new alignment checks.  Previously the alignment checks would
> have been done in a different place, but this lets us print more
> useful error messages.
> 
> Reviewed-by: Martijn Coenen <maco@...roid.com>
> Signed-off-by: Todd Kjos <tkjos@...gle.com>
> ---

Looks good.
Acked-by: Christian Brauner <christian.brauner@...ntu.com>