linux-kernel - Re: [PATCH v2 0/2] PCI: endpoint: Fix core_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211201150412.GA13833@lpieralisi>
Date:   Wed, 1 Dec 2021 15:04:12 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>, kishon@...com
Cc:     Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Xiaowei Bao <xiaowei.bao@....com>,
        Om Prakash Singh <omp@...dia.com>,
        Vidya Sagar <vidyas@...dia.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: endpoint: Fix core_init_notifier feature

On Thu, Sep 16, 2021 at 08:30:35PM +0900, Kunihiko Hayashi wrote:
> Gentle ping, are there any comments about this series?

Kishon,

can you have a look please ?

Thanks,
Lorenzo

> Thank you,
> 
> On 2021/09/01 14:15, Kunihiko Hayashi wrote:
> > This series has two fixes for core_init_notifier feature.
> > 
> > Fix the bug that the driver can't register its notifier function
> > if core_init_notifier == true and linkup_notifier == false.
> > 
> > If enabling the controller is delayed due to core_init_notifier,
> > accesses to the controller register should be avoided rather than
> > enabling the controller.
> > 
> > Changes since v1:
> > - Add Acked-by and Reviewed-by lines
> > 
> > Kunihiko Hayashi (2):
> >    PCI: endpoint: pci-epf-test: register notifier if only
> >      core_init_notifier is enabled
> >    PCI: designware-ep: Fix the access to DBI/iATU registers before
> >      enabling controller
> > 
> >   drivers/pci/controller/dwc/pcie-designware-ep.c | 81 +++++++++++++------------
> >   drivers/pci/endpoint/functions/pci-epf-test.c   |  2 +-
> >   2 files changed, 42 insertions(+), 41 deletions(-)
> > 
> 
> -- 
> ---
> Best Regards
> Kunihiko Hayashi