[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <163837398126.3058.11030158077196581603.b4-ty@arm.com>
Date: Wed, 1 Dec 2021 15:53:21 +0000
From: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
bcm-kernel-feedback-list@...adcom.com,
linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Florian Fainelli <f.fainelli@...il.com>,
Rob Herring <robh@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof WilczyĆski <kw@...ux.com>,
Jim Quinlan <jim2101024@...il.com>,
Nicolas Saenz Julienne <nsaenz@...nel.org>
Subject: Re: [PATCH v2 1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only
On Mon, 15 Nov 2021 13:20:00 +0200, Andy Shevchenko wrote:
> Use BIT() as __GENMASK() is for internal use only. The rationale
> of switching to BIT() is to provide better generated code. The
> GENMASK() against non-constant numbers may produce an ugly assembler
> code. On contrary the BIT() is simply converted to corresponding shift
> operation.
>
> Note, it's the only user of __GENMASK() in the kernel outside of its own realm.
>
> [...]
Applied to pci/brcmstb, thanks!
[1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only
https://git.kernel.org/lpieralisi/pci/c/6ec6eb949d
Thanks,
Lorenzo
Powered by blists - more mailing lists