linux-kernel - Re: [PATCH v3 2/2] block: cancel all throttled bios in del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YaeqXU82Nta+PhF6@slm.duckdns.org>
Date:   Wed, 1 Dec 2021 07:01:17 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     hch@...radead.org, axboe@...nel.dk, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH v3 2/2] block: cancel all throttled bios in del_gendisk()

On Wed, Dec 01, 2021 at 05:40:14PM +0800, Yu Kuai wrote:
> +	/*
> +	 * hold queue_lock to prevent concurrent with dispatching
> +	 * throttled bios by timer.
> +	 */
> +	spin_lock_irq(&q->queue_lock);
> +	rcu_read_lock();

Can you see whether it still needs rcu_read_lock() while holding queue_lock?
Now that all RCU flavors are merged, I think just holding the queue_lock
should be enough here.

Looks good otherwise.

Thanks.

-- 
tejun