lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20211201171356.GA15686@lpieralisi>
Date:   Wed, 1 Dec 2021 17:13:56 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof WilczyƄski <kw@...ux.com>,
        Jim Quinlan <jim2101024@...il.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>
Subject: Re: [PATCH v2 1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for
 internal use only

On Wed, Dec 01, 2021 at 06:01:46PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 01, 2021 at 03:53:21PM +0000, Lorenzo Pieralisi wrote:
> > On Mon, 15 Nov 2021 13:20:00 +0200, Andy Shevchenko wrote:
> > > Use BIT() as __GENMASK() is for internal use only. The rationale
> > > of switching to BIT() is to provide better generated code. The
> > > GENMASK() against non-constant numbers may produce an ugly assembler
> > > code. On contrary the BIT() is simply converted to corresponding shift
> > > operation.
> > > 
> > > Note, it's the only user of __GENMASK() in the kernel outside of its own realm.
> > > 
> > > [...]
> > 
> > Applied to pci/brcmstb, thanks!
> > 
> > [1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only
> >       https://git.kernel.org/lpieralisi/pci/c/6ec6eb949d
> 
> Thanks, but there is another patch which changes the logic a bit and cleans up
> more.
> 
>   From: Florian Fainelli <f.fainelli@...il.com>
>   Subject: [PATCH] PCI: brcmstb: Do not use __GENMASK

Right,

I pulled that one instead, thanks for the heads-up.

Lorenzo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ