linux-kernel - Re: [PATCH] spmi: pmic-arb: Add support for PMIC v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Dec 2021 15:06:23 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Vinod Koul <vkoul@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Dai <daidavid1@...eaurora.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH] spmi: pmic-arb: Add support for PMIC v7

Quoting Vinod Koul (2021-11-30 23:27:18)
> @@ -1169,8 +1270,12 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
>         pmic_arb = spmi_controller_get_drvdata(ctrl);
>         pmic_arb->spmic = ctrl;
>  
> +       /*
> +        * Don't use devm_ioremap_resource() as the resources are shared in
> +        * PMIC v7 onwards, so causing failure when mapping
> +        */
>         res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
> -       core = devm_ioremap_resource(&ctrl->dev, res);
> +       core = devm_ioremap(&ctrl->dev, res->start, resource_size(res));

What does this mean? We have two nodes in DT that have the same reg
properties? How does that work?

>         if (IS_ERR(core)) {
>                 err = PTR_ERR(core);
>                 goto err_put_ctrl;