linux-kernel - Re: [PATCH -next] mm: delete oversized WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Dec 2021 19:26:43 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Bixuan Cui <cuibixuan@...ux.alibaba.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, leon@...nel.org, w@....eu,
        keescook@...omium.org
Subject: Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc()
 calls

On Thu,  2 Dec 2021 10:06:24 +0800 Bixuan Cui <cuibixuan@...ux.alibaba.com> wrote:

> Delete the WARN_ON() and return NULL directly for oversized parameter
> in kvmalloc() calls.
> Also add unlikely().
> 
> Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls")
> Signed-off-by: Bixuan Cui <cuibixuan@...ux.alibaba.com>
> ---
> There are a lot of oversize warnings and patches about kvmalloc() calls
> recently. Maybe these warnings are not very necessary.

Or maybe they are.  Please let's take a look at these warnings, one at
a time.  If a large number of them are bogus then sure, let's disable
the runtime test.  But perhaps it's the case that calling code has
genuine issues and should be repaired.