linux-kernel - Re: [PATCH v2 2/2] i2c: virtio: fix completion handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211202153436.GA11644@axis.com>
Date:   Thu, 2 Dec 2021 16:34:37 +0100
From:   Vincent Whitchurch <vincent.whitchurch@...s.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     "jie.deng@...el.com" <jie.deng@...el.com>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "wsa@...nel.org" <wsa@...nel.org>, kernel <kernel@...s.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "conghui.chen@...el.com" <conghui.chen@...el.com>
Subject: Re: [PATCH v2 2/2] i2c: virtio: fix completion handling

On Thu, Nov 11, 2021 at 05:57:30PM +0100, Michael S. Tsirkin wrote:
> On Thu, Nov 11, 2021 at 05:04:12PM +0100, Vincent Whitchurch wrote:
> > -	wait_for_completion(&vi->completion);
> > +	/*
> > +	 * We only need to wait for the last one since the device is required
> > +	 * to complete requests in order.
> > +	 */
> 
> Hmm the spec only says:
> 
>     A device MUST guarantee the requests in the virtqueue being processed in order
>     if multiple requests are received at a time.
> 
> it does not seem to require using the buffers in order.
> In any case, just waiting for all of them in a loop
> seems cleaner and likely won't take longer ...

Thank you, I've fixed this in v3.