linux-kernel - Re: [PATCH v1 1/3] gpio: Get rid of duplicate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaoMuoONxbJb0prf@smile.fi.intel.com>
Date:   Fri, 3 Dec 2021 14:25:30 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Marc Zyngier <maz@...nel.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        Baruch Siach <baruch@...s.co.il>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Tony Lindgren <tony@...mide.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        Thierry Reding <treding@...dia.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        patches@...nsource.cirrus.com,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        linux-power <linux-power@...rohmeurope.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC..." 
        <linux-mediatek@...ts.infradead.org>, linux-pwm@...r.kernel.org,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-unisoc@...ts.infradead.org,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-tegra@...r.kernel.org, Ray Jui <rjui@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Scott Branden <sbranden@...adcom.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        Keerthy <j-keerthy@...com>, Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jonathan Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in
 the drivers

On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote:
> On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove these assignment all at once.
> >
> > For the details one may look into the of_gpio_dev_init() implementation.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> 
> I have a bad feeling about this but I've gone through the drivers in
> this patch and it seems like you don't update any of the drivers that
> use multiple child OF nodes so I can't really point out any obvious
> bug.

Yes, like I said it's just a series to kick off the conversion.
I left the corner cases to the last.

> I have another change I'm working on that's related, let me send it shortly.

Do you mean it should be attached to the series?

-- 
With Best Regards,
Andy Shevchenko