linux-kernel - Re: [PATCH] staging: vt6655: refactor byMinChannel to min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0fea904-1861-0003-1b04-6d2e966657da@gmail.com>
Date:   Sat, 4 Dec 2021 11:27:43 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Alberto Merciai <alb3rt0.m3rciai@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tommaso Merciai <tomm.merciai@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        Karolina Drobnik <karolinadrobnik@...il.com>,
        Lucas Henneman <lucas.henneman@...aro.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: refactor byMinChannel to min_channel

On 12/4/21 03:40, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "byMinChannel"
> into linux kernel coding style equivalent variable "min_channel".
> 
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@...il.com>
> ---
>   drivers/staging/vt6655/device.h      | 2 +-
>   drivers/staging/vt6655/device_main.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 6ea4165e4929..109d20a010ab 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -200,7 +200,7 @@ struct vnt_private {
>   	unsigned char byTopOFDMBasicRate;
>   	unsigned char byTopCCKBasicRate;
>   
> -	unsigned char byMinChannel;
> +	unsigned char min_channel;
>   	unsigned char max_channel;
>   
>   	unsigned char preamble_type;
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 313f0241d989..4d92b5df5312 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -228,7 +228,7 @@ static void device_init_registers(struct vnt_private *priv)
>   	spin_unlock_irqrestore(&priv->lock, flags);
>   
>   	/* Get Channel range */
> -	priv->byMinChannel = 1;
> +	priv->min_channel = 1;
>   	priv->max_channel = CB_MAX_CHANNEL;
>   
>   	/* Get Antena */
> 

Looks like this variable is set, but never used. Shouldn't it be just 
removed?

Same for max_channel (or byMaxChannel).




With regards,
Pavel Skripkin