linux-kernel - Re: [PATCH] staging: vt6655: refactor byMinChannel to min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a10f1013-069e-7f56-8a5b-80621af8a158@gmail.com>
Date:   Sat, 4 Dec 2021 12:22:59 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Alberto Merciai <alb3rt0.m3rciai@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tommaso Merciai <tomm.merciai@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        Karolina Drobnik <karolinadrobnik@...il.com>,
        Lucas Henneman <lucas.henneman@...aro.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: refactor byMinChannel to min_channel

On 12/4/21 12:09, Alberto Merciai wrote:
> On Sat, Dec 04, 2021 at 11:27:43AM +0300, Pavel Skripkin wrote:
>> Looks like this variable is set, but never used. Shouldn't it be just
>> removed?
>> 
>> Same for max_channel (or byMaxChannel).
> 
> To be honest, I would prefer leave them where they are. I'm only
> refactoring the code considering less the logic aspect.
> 
> I don't know if these variables will become usefull in a second
> moment.
> 
> Anyway, If you consider that this could be a good moment to remove
> them we can proceed.
> 
> What do you think about that?
> 

I think, it should be up to maintainers to decide, but them can be 
removed now and if somebody will need them later, he can bring them back 
without any pain. For now it's just useless memory usage.


I skimmed through priv fields usage and looks like many of them are just 
set, but never used. I guess, some kind of evolution removed all uses of 
them...




With regards,
Pavel Skripkin