linux-kernel - Re: [PATCH AUTOSEL 4.4 8/9] net: ptp: add a definition for the UDP port for IEEE 1588 general messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211204121847.GA15934@duo.ucw.cz>
Date:   Sat, 4 Dec 2021 13:18:47 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Vladimir Oltean <vladimir.oltean@....com>,
        Richard Cochran <richardcochran@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.4 8/9] net: ptp: add a definition for the UDP
 port for IEEE 1588 general messages

Hi!

> [ Upstream commit ec15baec3272bbec576f2ce7ce47765a8e9b7b1c ]
> 
> As opposed to event messages (Sync, PdelayReq etc) which require
> timestamping, general messages (Announce, FollowUp etc) do not.
> In PTP they are part of different streams of data.
> 
> IEEE 1588-2008 Annex D.2 "UDP port numbers" states that the UDP
> destination port assigned by IANA is 319 for event messages, and 320 for
> general messages. Yet the kernel seems to be missing the definition for
> general messages. This patch adds it.

This does not fix any bug in 4.4, right? We do not need it in stable.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)