linux-kernel - Re: [PATCH AUTOSEL 4.4 9/9] fs: ntfs: Limit NTFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211204122342.GB15934@duo.ucw.cz>
Date:   Sat, 4 Dec 2021 13:23:42 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>,
        Anton Altaparmakov <anton@...era.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-ntfs-dev@...ts.sourceforge.net
Subject: Re: [PATCH AUTOSEL 4.4 9/9] fs: ntfs: Limit NTFS_RW to page sizes
 smaller than 64k

Hi!

> [ Upstream commit 4eec7faf6775263d9e450ae7ee5bc4101d4a0bc9 ]
> 
> NTFS_RW code allocates page size dependent arrays on the stack. This
> results in build failures if the page size is 64k or larger.
> 
>   fs/ntfs/aops.c: In function 'ntfs_write_mst_block':
>   fs/ntfs/aops.c:1311:1: error:
> 	the frame size of 2240 bytes is larger than 2048 bytes
> 
> Since commit f22969a66041 ("powerpc/64s: Default to 64K pages for 64 bit
> book3s") this affects ppc:allmodconfig builds, but other architectures
> supporting page sizes of 64k or larger are also affected.

NAK, this will disable NTFS_RW support in 4.4 entirely.

> +++ b/fs/ntfs/Kconfig
> @@ -51,6 +51,7 @@ config NTFS_DEBUG
>  config NTFS_RW
>  	bool "NTFS write support"
>  	depends on NTFS_FS
> +	depends on PAGE_SIZE_LESS_THAN_64KB
>  	help
>  	  This enables the partial, but safe, write support in the NTFS driver.
>  

AFAICT CONFIG_PAGE_SIZE_LESS_THAN_64KB is not present in 4.4 (and
probably other) -stable kernels, nor it is queued to be added there.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)