| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <192d147f-d170-ac57-f376-c4b7a3b919aa@quicinc.com>
Date: Mon, 6 Dec 2021 10:24:32 +0530
From: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
To: Greg KH <greg@...ah.com>
CC: <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<devicetree@...r.kernel.org>, <pure.logic@...us-software.ie>,
<bjorn.andersson@...aro.org>, <robh@...nel.org>,
<linux-kernel@...r.kernel.org>, <quic_tsoni@...cinc.com>,
<quic_psodagud@...cinc.com>, <quic_satyap@...cinc.com>,
<quic_pheragu@...cinc.com>, <quic_rjendra@...cinc.com>,
<quic_sibis@...cinc.com>, <quic_saipraka@...cinc.com>
Subject: Re: [PATCH V2 5/8] soc: qcom: eud: Add driver support for Embedded
USB Debugger(EUD)
On 12/3/2021 4:34 PM, Greg KH wrote:
> On Thu, Dec 02, 2021 at 03:21:24PM +0530, Souradeep Chowdhury wrote:
>> Add support for control peripheral of EUD (Embedded USB Debugger) to
>> listen to events such as USB attach/detach, pet EUD to indicate software
>> is functional.Reusing the platform device kobj, sysfs entry 'enable' is
>> created to enable or disable EUD.
>>
>> To enable the eud the following needs to be done
>> echo 1 > /sys/bus/platform/.../enable
>>
>> To disable eud, following is the command
>> echo 0 > /sys/bus/platform/.../enable
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> ---
>> Documentation/ABI/testing/sysfs-driver-eud | 9 +
>> drivers/soc/qcom/Kconfig | 10 ++
>> drivers/soc/qcom/Makefile | 1 +
>> drivers/soc/qcom/qcom_eud.c | 268 +++++++++++++++++++++++++++++
>> 4 files changed, 288 insertions(+)
>> create mode 100644 Documentation/ABI/testing/sysfs-driver-eud
>> create mode 100644 drivers/soc/qcom/qcom_eud.c
>>
>> diff --git a/Documentation/ABI/testing/sysfs-driver-eud b/Documentation/ABI/testing/sysfs-driver-eud
>> new file mode 100644
>> index 0000000..eaf2e82
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-driver-eud
>> @@ -0,0 +1,9 @@
>> +What: /sys/bus/platform/drivers/eud/.../enable
>> +Date: October 2021
> You sent this patch in December 2021 :(
>
Ack
>
>> +Contact: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> +Description:
>> + The Enable/Disable sysfs interface for Embedded
>> + USB Debugger(EUD). This enables and disables the
>> + EUD based on a 1 or a 0 value. By enabling EUD,
>> + the user is able to activate the mini-usb hub of
>> + EUD for debug and trace capabilities.
>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>> index 79b568f..a4db41b 100644
>> --- a/drivers/soc/qcom/Kconfig
>> +++ b/drivers/soc/qcom/Kconfig
>> @@ -42,6 +42,16 @@ config QCOM_CPR
>> To compile this driver as a module, choose M here: the module will
>> be called qcom-cpr
>>
>> +config QCOM_EUD
>> + tristate "QCOM Embedded USB Debugger(EUD) Driver"
>> + select USB_ROLE_SWITCH
>> + help
>> + This module enables support for Qualcomm Technologies, Inc.
>> + Embedded USB Debugger (EUD). The EUD is a control peripheral
>> + which reports VBUS attach/detach events and has USB-based
>> + debug and trace capabilities. On selecting m, the module name
>> + that is built is qcom_eud.ko
>> +
>> config QCOM_GENI_SE
>> tristate "QCOM GENI Serial Engine Driver"
>> depends on ARCH_QCOM || COMPILE_TEST
>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
>> index ad675a6..3331a40 100644
>> --- a/drivers/soc/qcom/Makefile
>> +++ b/drivers/soc/qcom/Makefile
>> @@ -4,6 +4,7 @@ obj-$(CONFIG_QCOM_AOSS_QMP) += qcom_aoss.o
>> obj-$(CONFIG_QCOM_GENI_SE) += qcom-geni-se.o
>> obj-$(CONFIG_QCOM_COMMAND_DB) += cmd-db.o
>> obj-$(CONFIG_QCOM_CPR) += cpr.o
>> +obj-$(CONFIG_QCOM_EUD) += qcom_eud.o
>> obj-$(CONFIG_QCOM_GSBI) += qcom_gsbi.o
>> obj-$(CONFIG_QCOM_MDT_LOADER) += mdt_loader.o
>> obj-$(CONFIG_QCOM_OCMEM) += ocmem.o
>> diff --git a/drivers/soc/qcom/qcom_eud.c b/drivers/soc/qcom/qcom_eud.c
>> new file mode 100644
>> index 0000000..613ac41
>> --- /dev/null
>> +++ b/drivers/soc/qcom/qcom_eud.c
>> @@ -0,0 +1,268 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2015-2021, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +#include <linux/bitops.h>
>> +#include <linux/delay.h>
>> +#include <linux/err.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/io.h>
>> +#include <linux/iopoll.h>
>> +#include <linux/kernel.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/slab.h>
>> +#include <linux/sysfs.h>
>> +#include <linux/usb/role.h>
>> +
>> +#define EUD_REG_INT1_EN_MASK 0x0024
>> +#define EUD_REG_INT_STATUS_1 0x0044
>> +#define EUD_REG_CTL_OUT_1 0x0074
>> +#define EUD_REG_VBUS_INT_CLR 0x0080
>> +#define EUD_REG_CSR_EUD_EN 0x1014
>> +#define EUD_REG_SW_ATTACH_DET 0x1018
>> +#define EUD_REG_EUD_EN2 0x0000
>> +
>> +#define EUD_ENABLE BIT(0)
>> +#define EUD_INT_PET_EUD BIT(0)
>> +#define EUD_INT_VBUS BIT(2)
>> +#define EUD_INT_SAFE_MODE BIT(4)
>> +#define EUD_INT_ALL (EUD_INT_VBUS|EUD_INT_SAFE_MODE)
>> +
>> +struct eud_chip {
>> + struct device *dev;
>> + struct usb_role_switch *role_sw;
>> + void __iomem *eud_reg_base;
>> + void __iomem *eud_mode_mgr2_phys_base;
>> + unsigned int int_status;
>> + int eud_irq;
>> + bool enable;
>> + bool usb_attach;
>> +
>> +};
>> +
>> +static int enable_eud(struct eud_chip *priv)
>> +{
>> + writel(EUD_ENABLE, priv->eud_reg_base + EUD_REG_CSR_EUD_EN);
>> + writel(EUD_INT_VBUS | EUD_INT_SAFE_MODE,
>> + priv->eud_reg_base + EUD_REG_INT1_EN_MASK);
>> + writel(1, priv->eud_mode_mgr2_phys_base + EUD_REG_EUD_EN2);
>> +
>> + return usb_role_switch_set_role(priv->role_sw, USB_ROLE_DEVICE);
>> +}
>> +
>> +static void disable_eud(struct eud_chip *priv)
>> +{
>> + writel(0, priv->eud_reg_base + EUD_REG_CSR_EUD_EN);
>> + writel(0, priv->eud_mode_mgr2_phys_base + EUD_REG_EUD_EN2);
>> +}
>> +
>> +static ssize_t enable_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + struct eud_chip *chip = dev_get_drvdata(dev);
>> +
>> + return sysfs_emit(buf, "%d\n", chip->enable);
>> +}
>> +
>> +static ssize_t enable_store(struct device *dev,
>> + struct device_attribute *attr,
>> + const char *buf, size_t count)
>> +{
>> + struct eud_chip *chip = dev_get_drvdata(dev);
>> + bool enable;
>> + int ret;
>> +
>> + if (kstrtobool(buf, &enable))
>> + return -EINVAL;
>> +
>> + if (enable) {
>> + ret = enable_eud(chip);
>> + if (!ret)
>> + chip->enable = enable;
>> + } else {
>> + disable_eud(chip);
>> + }
>> +
>> + return count;
>> +}
>> +
>> +static DEVICE_ATTR_RW(enable);
>> +
>> +static struct attribute *eud_attrs[] = {
>> + &dev_attr_enable.attr,
>> + NULL,
>> +};
>> +
>> +static struct attribute_group attr_group = {
>> + .attrs = eud_attrs,
>> +};
>> +
>> +static const struct attribute_group *attr_groups[] = {
>> + &attr_group,
>> + NULL
>> +};
> ATTRIBUTE_GROUPS()?
Ack
>
> thanks,
>
> greg k-h
Powered by blists - more mailing lists