linux-kernel - Re: [PATCH 05/15] arm64: dts: qcom: sm8450: Add reserved memory nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya2ixVvjbWf7FibZ@matsya>
Date:   Mon, 6 Dec 2021 11:12:29 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/15] arm64: dts: qcom: sm8450: Add reserved memory nodes

On 01-12-21, 16:11, Konrad Dybcio wrote:
> 
> On 01.12.2021 08:29, Vinod Koul wrote:
> > Add the reserved memory nodes for SM8450. This is based on the downstream
> > documentation.
> >
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm8450.dtsi | 221 +++++++++++++++++++++++++++
> >  1 file changed, 221 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > index f0b9e80238a2..79aead4cba66 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > @@ -310,6 +310,227 @@ CLUSTER_PD: cpu-cluster0 {
> >  		};
> >  	};
> >  
> > +	reserved_memory: reserved-memory {
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> > +
> > +		hyp_mem: memory@...00000 {
> > +			no-map;
> > +			reg = <0x0 0x80000000 0x0 0x600000>;
> > +		};
> 
> All nodes in this patch put no-map before reg, which is precisely not the way
> 
> it's done in all other qcom DTs...

True, will update it to be consistent across

> 
> [...]
> 
> 
> > +
> > +		/* uefi region can be reused by apps */
> 
> What apps? Facebook? TikTok? Capitalization makes a difference in this
> 
> specific case..

Am sure facebook might like you comment, but lets fix that up to not
give them such opinion :)

-- 
~Vinod