linux-kernel - Re: [PATCH 04/15] arm64: dts: qcom: sm8450-qrd: Add reserved gpio range for QRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya2lXXDzN83pYxqn@matsya>
Date:   Mon, 6 Dec 2021 11:23:33 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/15] arm64: dts: qcom: sm8450-qrd: Add reserved gpio
 range for QRD

On 01-12-21, 16:07, Konrad Dybcio wrote:
> 
> On 01.12.2021 08:29, Vinod Koul wrote:
> > Some tlmm gpios are reserved, so mark them as such in QRD DTS
> >
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > index 127d32502555..8dcd41c4e5ab 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > @@ -24,6 +24,10 @@ &qupv3_id_0 {
> >  	status = "okay";
> >  };
> >  
> > +&tlmm {
> > +	gpio-reserved-ranges = <28 4>, <36 4>;
> > +};
> > +
> >  &uart7 {
> >  	status = "okay";
> >  };
> >
> Personally I'd squash this into the patch that introduced the DT and

I feel it is the right things to do, a patch should not touch a
different file. soc dts and board dts and two different entities and
should be patched separately!

> move it to the end of the series, but I reckon it's fine either way..
> 
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Thanks for the detailed review.

-- 
~Vinod