linux-kernel - Re: [v1 1/5] arm64: dts: mediatek: Correct system timer clock of MT8192

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211206164150.wigqbwo6kdkwi35r@notapiano>
Date:   Mon, 6 Dec 2021 11:41:50 -0500
From:   Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
To:     Chun-Jie Chen <chun-jie.chen@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Nicolas Boichat <drinkcat@...omium.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        srv_heupstream@...iatek.com,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [v1 1/5] arm64: dts: mediatek: Correct system timer clock of
 MT8192

Hi Chun-Jie,

thanks for the patch! However, can you please improve the commit message? Here's
a possible suggestion:

    When the initial devicetree for mt8192 was added in 48489980e27e ("arm64:
    dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile"), the
    clock driver for mt8192 was not yet upstream, so the clock property nodes
    were set to the clk26m clock as a placeholder.

    Given that the clock driver has since been added through 710573dee31b ("clk:
    mediatek: Add MT8192 basic clocks support"), as well as its dt-bindings
    through f35f1a23e0e1 ("clk: mediatek: Add dt-bindings of MT8192 clocks") and
    devicetree nodes through 5d2b897bc6f5 ("arm64: dts: mediatek: Add mt8192
    clock controllers"), fix the systimer clock property to point to the actual
    clock.

Then you could use the same message for the other commits, just updating which
clock is being fixed in the last sentence there. With that improved commit
message:

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Thanks,
Nícolas

> 
> Signed-off-by: Chun-Jie Chen <chun-jie.chen@...iatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index c7c7d4e017ae..2b63d2ea6cb6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -312,7 +312,7 @@
>  				     "mediatek,mt6765-timer";
>  			reg = <0 0x10017000 0 0x1000>;
>  			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH 0>;
> -			clocks = <&clk26m>;
> +			clocks = <&topckgen CLK_TOP_CSW_F26M_D2>;
>  			clock-names = "clk13m";
>  		};
>  
> -- 
> 2.18.0
> 
>