linux-kernel - Re: [PATCH v2] uacce: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ya264Nd3nfuHeZF0@kroah.com>
Date:   Mon, 6 Dec 2021 08:25:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kai Ye <yekai13@...wei.com>
Cc:     linux-accelerators@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, zhangfei.gao@...aro.org,
        wangzhou1@...ilicon.com
Subject: Re: [PATCH v2] uacce: use sysfs_emit instead of sprintf

On Mon, Dec 06, 2021 at 03:09:43PM +0800, Kai Ye wrote:
> Use the sysfs_emit to replace sprintf. sprintf may cause
> output defect in sysfs content, it is better to use new
> added sysfs_emit function which knows the size of the
> temporary buffer.

For these calls you have replaced, there is no real reason to change as
it is obvious that the buffer is big enough.  So there is no "may cause
output defect" here.

Also, feel free to use the full 72 columns for your changelog text.

> 
> Signed-off-by: Kai Ye <yekai13@...wei.com>
> 
> changes v1->v2:
> 	modfiy the comments.
> ---

As per the documentation, the "changes..." lines go below the --- line
so that git will remove them automatically.

Please fix up and resend a v3.

thanks,

greg k-h