linux-kernel - Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a412f16-9375-32ae-cbda-ae9f38332887@canonical.com>
Date:   Tue, 7 Dec 2021 17:27:22 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Tony Lindgren <tony@...mide.com>,
        Roger Quadros <rogerq@...nel.org>, devicetree@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect
 unevaluatedProperties

On 07/12/2021 16:54, Rob Herring wrote:
> On Tue, Dec 7, 2021 at 3:12 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...onical.com> wrote:
>>
>> On 06/12/2021 18:42, Rob Herring wrote:
>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>>> has a warning:
>>>
>>> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@...00000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@...000' were unexpected)
>>>
>>> The child node definition for GPMC is not a complete binding, so specifying
>>> 'unevaluatedProperties: false' for it is not correct and should be
>>> dropped.
>>>
>>> Fixup the unnecessary 'allOf' while we're here.
>>>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>>> Cc: Tony Lindgren <tony@...mide.com>
>>> Cc: Roger Quadros <rogerq@...nel.org>
>>> Signed-off-by: Rob Herring <robh@...nel.org>
>>> ---
>>>  .../devicetree/bindings/memory-controllers/ti,gpmc.yaml      | 5 +----
>>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>
>> Looks good. Rob, do you want to take it via your tree or I should handle it?
> 
> I'll take it given there's also the somewhat related "dt-bindings:
> mtd: ti,gpmc-nand: Add missing 'rb-gpios'"

Sure, then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>


Best regards,
Krzysztof