linux-kernel - Re: [PATCH v2 1/3] gpio: Get rid of duplicate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5464ae4-d8e9-6fab-4855-3ca1ba58d705@fi.rohmeurope.com>
Date:   Tue, 7 Dec 2021 05:32:46 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Marc Zyngier <maz@...nel.org>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Baruch Siach <baruch@...s.co.il>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Tony Lindgren <tony@...mide.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        Thierry Reding <treding@...dia.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "patches@...nsource.cirrus.com" <patches@...nsource.cirrus.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        linux-power <linux-power@...rohmeurope.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "linux-unisoc@...ts.infradead.org" <linux-unisoc@...ts.infradead.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
CC:     Ray Jui <rjui@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Scott Branden <sbranden@...adcom.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        Keerthy <j-keerthy@...com>, Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jonathan Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v2 1/3] gpio: Get rid of duplicate of_node assignment in
 the drivers

On 12/6/21 15:18, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove these assignment all at once.
> 
> For the details one may look into the of_gpio_dev_init() implementation.
> 
> While at it, remove duplicate parent device assignment where it is the case.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: mentioned parent removal (Linus), dropped change of the removed code
>   drivers/gpio/gpio-adnp.c            | 1 -
>   drivers/gpio/gpio-amdpt.c           | 4 +---
>   drivers/gpio/gpio-bd71828.c         | 1 -

for bd71828:
Reviewed-By: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>

-- 
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~