linux-kernel - Re: [kbuild-all] Re: [paulmck-rcu:dev.2021.12.02a 31/43] include/asm-generic/barrier.h:70:30: warning: 'kcsan_rmb' is static but used in inline function 'pte_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Dec 2021 08:32:26 +0800
From:   Rong Chen <rong.a.chen@...el.com>
To:     Marco Elver <elver@...gle.com>, kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        "Paul E. McKenney" <paulmck@...nel.org>
Subject: Re: [kbuild-all] Re: [paulmck-rcu:dev.2021.12.02a 31/43]
 include/asm-generic/barrier.h:70:30: warning: 'kcsan_rmb' is static but used
 in inline function 'pte_offset_kernel' which is not static



On 12/4/21 21:02, Marco Elver wrote:
> On Sat, 4 Dec 2021 at 06:33, kernel test robot <lkp@...el.com> wrote:
> [...]
>>>> include/asm-generic/barrier.h:70:30: warning: 'kcsan_rmb' is static but used in inline function 'pte_offset_kernel' which is not static
>>        70 | #define smp_rmb()       do { kcsan_rmb(); __smp_rmb(); } while (0)
>>           |                              ^~~~~~~~~
>>     arch/alpha/include/asm/pgtable.h:303:9: note: in expansion of macro 'smp_rmb'
>>       303 |         smp_rmb(); /* see above */
>>           |         ^~~~~~~
>>>> include/asm-generic/barrier.h:70:30: warning: 'kcsan_rmb' is static but used in inline function 'pmd_offset' which is not static
>>        70 | #define smp_rmb()       do { kcsan_rmb(); __smp_rmb(); } while (0)
>>           |                              ^~~~~~~~~
>>     arch/alpha/include/asm/pgtable.h:293:9: note: in expansion of macro 'smp_rmb'
>>       293 |         smp_rmb(); /* see above */
>>           |         ^~~~~~~
> I had been wondering if barriers could be static __always_inline, like
> we do for atomic_t operations. Apparently this answers that questions.
>
> This should fix it:
> https://lkml.kernel.org/r/20211204125703.3344454-1-elver@google.com
>
> Unrelatedly, I wonder if I can get the test robot to also check some
> of my branches:

Hi Marco,

We have added it into our monitor list.

Best Regards,
Rong Chen

> https://git.kernel.org/pub/scm/linux/kernel/git/melver/linux.git/
> That'd be very useful, to catch things like this early, and avoid
> disturbing Paul too much. :-)
>
> Thanks,
> -- Marco