linux-kernel - Re: [PATCH net-next] Revert "net: hns3: add void before function which don't receive ret"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211206163422.0055f67b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 6 Dec 2021 16:34:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leonro@...dia.com>,
        Guangbin Huang <huangguangbin2@...wei.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        Salil Mehta <salil.mehta@...wei.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>
Subject: Re: [PATCH net-next] Revert "net: hns3: add void before function
 which don't receive ret"

On Sun, 5 Dec 2021 14:18:21 +0200 Leon Romanovsky wrote:
> On Sun, Dec 05, 2021 at 01:51:37PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@...dia.com>
> > 
> > There are two issues with this patch:
> > 1. devlink_register() doesn't return any value. It is already void.
> > 2. It is not kernel coding at all to cast return type to void.
> > 
> > This reverts commit 5ac4f180bd07116c1e57858bc3f6741adbca3eb6.
> > 
> > Link: https://lore.kernel.org/all/Yan8VDXC0BtBRVGz@unreal
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > ---
> >  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
> >  drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)  
> 
> It was already sent, but not merged yet.
> https://lore.kernel.org/all/20211204012448.51360-1-huangguangbin2@huawei.com

Indeed, Guangbin in the future please make sure to CC the person whose
feedback the patches are based on.