linux-kernel - Re: [PATCH v2 1/3] of: Move simple-framebuffer device handling from simplefb to of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <011d10c1-9c2c-8b4f-ede1-987ac678701b@suse.de>
Date:   Tue, 7 Dec 2021 10:03:46 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Hector Martin <marcan@...can.st>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Javier Martinez Canillas <javier@...hile0.org>,
        Pekka Paalanen <ppaalanen@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] of: Move simple-framebuffer device handling from
 simplefb to of



Am 07.12.21 um 10:02 schrieb Thomas Zimmermann:
> Hi
> 
> Am 07.12.21 um 08:29 schrieb Hector Martin:
>> This code is required for both simplefb and simpledrm, so let's move it
>> into the OF core instead of having it as an ad-hoc initcall in the
>> drivers.
>>
>> Signed-off-by: Hector Martin <marcan@...can.st>
> 
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

Well, please don't take this as a review. :)

> 
> This looks much better than before. Thank you.
> 
>> ---
>>   drivers/of/platform.c          |  5 +++++
>>   drivers/video/fbdev/simplefb.c | 21 +--------------------
>>   2 files changed, 6 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
>> index b3faf89744aa..e097f40b03c0 100644
>> --- a/drivers/of/platform.c
>> +++ b/drivers/of/platform.c
>> @@ -540,6 +540,11 @@ static int __init 
>> of_platform_default_populate_init(void)
>>           of_node_put(node);
>>       }
>> +    for_each_child_of_node(of_chosen, node) {
>> +        if (of_device_is_compatible(node, "simple-framebuffer"))
>> +            of_platform_device_create(node, NULL, NULL);
>> +    }
>> +
>>       /* Populate everything else. */
>>       of_platform_default_populate(NULL, NULL, NULL);
>> diff --git a/drivers/video/fbdev/simplefb.c 
>> b/drivers/video/fbdev/simplefb.c
>> index b63074fd892e..57541887188b 100644
>> --- a/drivers/video/fbdev/simplefb.c
>> +++ b/drivers/video/fbdev/simplefb.c
>> @@ -541,26 +541,7 @@ static struct platform_driver simplefb_driver = {
>>       .remove = simplefb_remove,
>>   };
>> -static int __init simplefb_init(void)
>> -{
>> -    int ret;
>> -    struct device_node *np;
>> -
>> -    ret = platform_driver_register(&simplefb_driver);
>> -    if (ret)
>> -        return ret;
>> -
>> -    if (IS_ENABLED(CONFIG_OF_ADDRESS) && of_chosen) {
>> -        for_each_child_of_node(of_chosen, np) {
>> -            if (of_device_is_compatible(np, "simple-framebuffer"))
>> -                of_platform_device_create(np, NULL, NULL);
>> -        }
>> -    }
>> -
>> -    return 0;
>> -}
>> -
>> -fs_initcall(simplefb_init);
>> +module_platform_driver(simplefb_driver);
>>   MODULE_AUTHOR("Stephen Warren <swarren@...dotorg.org>");
>>   MODULE_DESCRIPTION("Simple framebuffer driver");
>>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)