linux-kernel - Re: [PATCH v2 3/3] drm/simpledrm: Add XRGB2101010 format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbc244d0-8ea5-bb1a-0c71-178f390ea748@suse.de>
Date:   Tue, 7 Dec 2021 10:31:59 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Hector Martin <marcan@...can.st>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Javier Martinez Canillas <javier@...hile0.org>,
        Pekka Paalanen <ppaalanen@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] drm/simpledrm: Add XRGB2101010 format

Hi

Am 07.12.21 um 08:29 schrieb Hector Martin:
> This is the format used by the bootloader framebuffer on Apple ARM64
> platforms.
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Hector Martin <marcan@...can.st>
> ---
>   drivers/gpu/drm/tiny/simpledrm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
> index 2f999915b9aa..edadfd9ee882 100644
> --- a/drivers/gpu/drm/tiny/simpledrm.c
> +++ b/drivers/gpu/drm/tiny/simpledrm.c
> @@ -571,7 +571,7 @@ static const uint32_t simpledrm_default_formats[] = {
>   	//DRM_FORMAT_XRGB1555,
>   	//DRM_FORMAT_ARGB1555,
>   	DRM_FORMAT_RGB888,
> -	//DRM_FORMAT_XRGB2101010,
> +	DRM_FORMAT_XRGB2101010,
>   	//DRM_FORMAT_ARGB2101010,

You should also enable DRM_FORMAT_ARGB2101010 here. You added the 
conversion function, so DRM can deal with it. Having an alpha channel 
isn't typically supported for primary planes, but the format is listed 
in SIMPLEFB_FORMATS. [1]

With this change:

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Best regards

[1] 
https://elixir.bootlin.com/linux/latest/source/include/linux/platform_data/simplefb.h#L16

>   };
>   
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)