linux-kernel - [pdx86-platform-drivers-x86:review-hans 41/44] drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous prototype for 'yogabook_wmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Dec 2021 09:42:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yauhen Kharuzhy <jekhor@...il.com>
Cc:     kbuild-all@...ts.01.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: [pdx86-platform-drivers-x86:review-hans 41/44]
 drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous
 prototype for 'yogabook_wmi_suspend'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
head:   cb01df9ef827442739051c6457962a5c6bc85d99
commit: 4709e8b835ec25e8627844e9927804f814b64fd4 [41/44] platform/x86: lenovo-yogabook-wmi: Add driver for Lenovo Yoga Book
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20211207/202112070945.X05c2wgI-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=4709e8b835ec25e8627844e9927804f814b64fd4
        git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
        git fetch --no-tags pdx86-platform-drivers-x86 review-hans
        git checkout 4709e8b835ec25e8627844e9927804f814b64fd4
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous prototype for 'yogabook_wmi_suspend' [-Wmissing-prototypes]
     278 | __maybe_unused int yogabook_wmi_suspend(struct device *dev)
         |                    ^~~~~~~~~~~~~~~~~~~~
>> drivers/platform/x86/lenovo-yogabook-wmi.c:294:20: warning: no previous prototype for 'yogabook_wmi_resume' [-Wmissing-prototypes]
     294 | __maybe_unused int yogabook_wmi_resume(struct device *dev)
         |                    ^~~~~~~~~~~~~~~~~~~


vim +/yogabook_wmi_suspend +278 drivers/platform/x86/lenovo-yogabook-wmi.c

   277	
 > 278	__maybe_unused int yogabook_wmi_suspend(struct device *dev)
   279	{
   280		struct wmi_device *wdev = container_of(dev, struct wmi_device, dev);
   281		struct yogabook_wmi *data = dev_get_drvdata(dev);
   282	
   283		set_bit(YB_SUSPENDED, &data->flags);
   284	
   285		flush_work(&data->work);
   286	
   287		/* Turn off the pen button at sleep */
   288		if (test_bit(YB_DIGITIZER_IS_ON, &data->flags))
   289			yogabook_wmi_do_action(wdev, YB_PAD_DISABLE);
   290	
   291		return 0;
   292	}
   293	
 > 294	__maybe_unused int yogabook_wmi_resume(struct device *dev)
   295	{
   296		struct wmi_device *wdev = container_of(dev, struct wmi_device, dev);
   297		struct yogabook_wmi *data = dev_get_drvdata(dev);
   298	
   299		if (test_bit(YB_KBD_IS_ON, &data->flags)) {
   300			/* Ensure keyboard touchpad is on before we call KBLC() */
   301			acpi_device_set_power(data->kbd_adev, ACPI_STATE_D0);
   302			yogabook_wmi_set_kbd_backlight(wdev, data->brightness);
   303		}
   304	
   305		if (test_bit(YB_DIGITIZER_IS_ON, &data->flags))
   306			yogabook_wmi_do_action(wdev, YB_PAD_ENABLE);
   307	
   308		clear_bit(YB_SUSPENDED, &data->flags);
   309	
   310		return 0;
   311	}
   312	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org