linux-kernel - Re: [PATCH] drm/bridge: parade-ps8640: Add backpointer to drm_device in drm_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+cxXhkmsUMCCJrvbz76nx-ctzSZhg0BFb50qD3nzUon3-Gp+w@mail.gmail.com>
Date:   Mon, 6 Dec 2021 17:44:05 -0800
From:   Philip Chen <philipchen@...omium.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     dri-devel@...ts.freedesktop.org, Lyude Paul <lyude@...hat.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jonas Karlman <jonas@...boo.se>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: parade-ps8640: Add backpointer to drm_device
 in drm_dp_aux

Hi

On Mon, Dec 6, 2021 at 4:29 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> When we added the support for the AUX channel in commit 13afcdd7277e
> ("drm/bridge: parade-ps8640: Add support for AUX channel") we forgot
> to set "drm_dev" to avoid the warning splat at the beginning of
> drm_dp_aux_register(). Since everything was working I guess I never
> noticed the splat when testing against mainline. In any case, it's
> easy to fix. This is basically just like commit 6cba3fe43341 ("drm/dp:
> Add backpointer to drm_device in drm_dp_aux") but just for the
> parade-ps8640.
>
> Fixes: 13afcdd7277e ("drm/bridge: parade-ps8640: Add support for AUX channel")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 26898042ba3d..818704bf5e86 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -449,6 +449,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
>         if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
>                 return -EINVAL;
>
> +       ps_bridge->aux.drm_dev = bridge->dev;
>         ret = drm_dp_aux_register(&ps_bridge->aux);
>         if (ret) {
>                 dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
> --
> 2.34.1.400.ga245620fadb-goog
>

Signed-off-by: Philip Chen <philipchen@...omium.org>