linux-kernel - Re: [PATCH] sound: ppc: beep: fix clang -Wimplicit-fallthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Dec 2021 15:37:20 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     perex@...ex.cz, tiwai@...e.com, nathan@...nel.org,
        ndesaulniers@...gle.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Subject: Re: [PATCH] sound: ppc: beep: fix clang -Wimplicit-fallthrough

On Tue, 07 Dec 2021 12:00:53 +0100,
Anders Roxell wrote:
> 
> Clang warns:
> 
> sound/ppc/beep.c:103:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>         case SND_TONE: break;
>         ^
> sound/ppc/beep.c:103:2: note: insert 'break;' to avoid fall-through
>         case SND_TONE: break;
>         ^
>         break;
> 1 warning generated.
> 
> Clang is more pedantic than GCC, which does not warn when failing
> through to a case that is just break or return. Clang's version
> is more in line with the kernel's own stance in deprecated.rst.
> Add athe missing break to silence the warning.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Thanks, applied.


Takashi