linux-kernel - Re: [PATCH] phy: tegra: add missing put_device() call in tegra210_xusb_padctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e57c1c99-0743-c785-24e3-44654e4991f1@gmail.com>
Date:   Tue, 7 Dec 2021 17:37:48 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Qing Wang <wangqing@...o.com>, JC Kuo <jckuo@...dia.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-phy@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: tegra: add missing put_device() call in
 tegra210_xusb_padctl_probe()

07.12.2021 17:35, Dmitry Osipenko пишет:
> 07.12.2021 15:56, Qing Wang пишет:
>> From: Wang Qing <wangqing@...o.com>
>>
>> of_find_device_by_node() takes a reference to the embedded struct device 
>> which needs to be dropped when error return.
>>
>> Signed-off-by: Wang Qing <wangqing@...o.com>
>> ---
>>  drivers/phy/tegra/xusb-tegra210.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-tegra210.c
>> index eedfc7c..05a0800
>> --- a/drivers/phy/tegra/xusb-tegra210.c
>> +++ b/drivers/phy/tegra/xusb-tegra210.c
>> @@ -3170,8 +3170,10 @@ tegra210_xusb_padctl_probe(struct device *dev,
>>  		goto out;
>>  	}
>>  
>> -	if (!platform_get_drvdata(pdev))
>> +	if (!platform_get_drvdata(pdev)) {
>> +		put_device(&pdev->dev);
>>  		return ERR_PTR(-EPROBE_DEFER);
>> +	}
>>  
>>  	padctl->regmap = dev_get_regmap(&pdev->dev, "usb_sleepwalk");
>>  	if (!padctl->regmap)
>>
> 
> What if dev_get_regmap() fails? What if driver is removed?
> 
> Please either fix it properly or don't fix it.
> 

My bad, I see now in the code that this dev_get_regmap() fail is okay.
Nevertheless the driver removal is incorrect.