linux-kernel - Re: [PATCH v2] selftests: net: Correct case name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db7382d1-8bb5-c0c1-2627-a3e6b98aef4e@fujitsu.com>
Date:   Wed, 8 Dec 2021 03:28:04 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     David Ahern <dsahern@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "shuah@...nel.org" <shuah@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jie2x Zhou <jie2x.zhou@...el.com>,
        "Li Zhijian(intel)" <zhijianx.li@...el.com>
Subject: Re: [PATCH v2] selftests: net: Correct case name



On 08/12/2021 11:01, David Ahern wrote:
> On 12/6/21 11:05 PM, lizhijian@...itsu.com wrote:
>>> #################################################################
>>> With VRF
>>>
>>> TEST: Raw socket bind to local address - ns-A IP                              [ OK ]
>>> TEST: Raw socket bind to local address after device bind - ns-A IP            [ OK ]
>>> TEST: Raw socket bind to local address after VRF bind - ns-A IP               [ OK ]
>>> TEST: Raw socket bind to local address - VRF IP                               [FAIL]
>>>
>> i found that above case failed with "server: error binding socket: 99: Cannot assign requested address"
>> i have manually check it with below command after setup(), same errors:
>>
>> # ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b
>> 05:55:11 server: error binding socket: 99: Cannot assign requested address
>>
>> But when i specified specific network interface, it works
>> # ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b -I red
>> # echo $?
>> 0
>> # ip netns exec ns-A nettest -s -R -P icmp -l 172.16.3.1 -b
>> 06:01:55 server: error binding socket: 99: Cannot assign requested address
>> # echo $?
>> 1
>>
>>
>> So i wonder if i missed something ?
>>
> That test should be a negative test as is the first one in that group -
> in both cases the address bind should fail since the socket is not in
> the VRF but the address is. The first on currently shows "OK" but that
> is because of 5cad8bce26e01 that made changes to the config to validate
> MD5 changes. Will send a patch to fix.
>
Got it, thanks a lot for your help.
I'm looking forward to it :)

Thanks
Zhijian