linux-kernel - Re: [PATCH v2] selftests: net: Correct case name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d92af7d-5a84-4a5d-fd98-37f969ac4c23@fujitsu.com>
Date:   Wed, 8 Dec 2021 03:38:27 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     David Ahern <dsahern@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "shuah@...nel.org" <shuah@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jie2x Zhou <jie2x.zhou@...el.com>,
        "Li Zhijian(intel)" <zhijianx.li@...el.com>
Subject: Re: [PATCH v2] selftests: net: Correct case name



On 08/12/2021 11:14, David Ahern wrote:
> On 12/6/21 11:05 PM, lizhijian@...itsu.com wrote:
>>> # TESTS=bind6 ./fcnal-test.sh
>>>
>>> ###########################################################################
>>> IPv6 address binds
>>> ###########################################################################
>>>
>>>
>>> #################################################################
>>> No VRF
>>>
>>> TEST: Raw socket bind to local address - ns-A IPv6                            [FAIL]
> This one passes for me.
Err, i didn't notice this one when i sent this mail. Since it was passed too in my
previous multiple runs.




>
> Can you run the test with '-v -p'? -v will give you the command line
> that is failing. -p will pause the tests at the failure. From there you
> can do:
>
> ip netns exec ns-A bash
>
> Look at the routing - no VRF is involved so the address should be local
> to the device and the loopback. Run the test manually to see if it
> really is failing.

thanks for your advice, i will take a look if it appears again.



>
>
>>> TEST: Raw socket bind to local address after device bind - ns-A IPv6          [ OK ]
>>> TEST: Raw socket bind to local address - ns-A loopback IPv6                   [ OK ]
>>> TEST: Raw socket bind to local address after device bind - ns-A loopback IPv6  [ OK ]
>>> TEST: TCP socket bind to local address - ns-A IPv6                            [ OK ]
>>> TEST: TCP socket bind to local address after device bind - ns-A IPv6          [ OK ]
>>> TEST: TCP socket bind to out of scope local address - ns-A loopback IPv6      [FAIL]
> This one seems to be a new problem. The socket is bound to eth1 and the
> address bind is to an address on loopback. That should not be working.

My colleague had another thread with the verbose detailed message
https://lore.kernel.org/netdev/PH0PR11MB4792DC680F7E383D72C2E8C5C56E9@PH0PR11MB4792.namprd11.prod.outlook.com/



>
>>> #################################################################
>>> With VRF
>>>
>>> TEST: Raw socket bind to local address after vrf bind - ns-A IPv6             [ OK ]
>>> TEST: Raw socket bind to local address after device bind - ns-A IPv6          [ OK ]
>>> TEST: Raw socket bind to local address after vrf bind - VRF IPv6              [ OK ]
>>> TEST: Raw socket bind to local address after device bind - VRF IPv6           [ OK ]
>>> TEST: Raw socket bind to invalid local address after vrf bind - ns-A loopback IPv6  [ OK ]
>>> TEST: TCP socket bind to local address with VRF bind - ns-A IPv6              [ OK ]
>>> TEST: TCP socket bind to local address with VRF bind - VRF IPv6               [ OK ]
>>> TEST: TCP socket bind to local address with device bind - ns-A IPv6           [ OK ]
>>> TEST: TCP socket bind to VRF address with device bind - VRF IPv6              [FAIL]
> This failure is similar to the last one. Need to see if a recent commit
> changed something.

Good to know this


Thanks
Zhijian

>
>
>>> TEST: TCP socket bind to invalid local address for VRF - ns-A loopback IPv6   [ OK ]
>>> TEST: TCP socket bind to invalid local address for device bind - ns-A loopback IPv6  [ OK ]
>>
>> Thanks
>> Zhijian
>>
>>