linux-kernel - Re: selftests/net/fcnal-test.sh: ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB47924ED34AE948FB0E6CF933C56F9@PH0PR11MB4792.namprd11.prod.outlook.com>
Date:   Wed, 8 Dec 2021 03:50:36 +0000
From:   "Zhou, Jie2X" <jie2x.zhou@...el.com>
To:     David Ahern <dsahern@...il.com>, Jakub Kicinski <kuba@...nel.org>,
        "lizhijian@...itsu.com" <lizhijian@...itsu.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Li, Philip" <philip.li@...el.com>, lkp <lkp@...el.com>,
        "Ma, XinjianX" <xinjianx.ma@...el.com>,
        "Li, ZhijianX" <zhijianx.li@...el.com>
Subject: Re: selftests/net/fcnal-test.sh: ipv6_ping test failed

hi,

  man ip, the output about exit value is like following.
  "Exit status is 0 if command was successful, and 1 if there is a syntax error.  If an error was reported by the kernel exit status is 2."
  Did the following COMMAND have syntax error? If not, should I still change the expected rc from 2 to 1?

#######################################################
HINT: Fails since VRF device does not support linklocal or multicast

COMMAND: ip netns exec ns-A /bin/ping6 -c1 -w1 fe80::7c4c:bcff:fe66:a63a%red
ping: sendmsg: Network is unreachable
PING fe80::7c4c:bcff:fe66:a63a%red(fe80::7c4c:bcff:fe66:a63a%red) 56 data bytes

--- fe80::7c4c:bcff:fe66:a63a%red ping statistics ---
1 packets transmitted, 0 received, 100% packet loss, time 0ms

TEST: ping out, VRF bind - ns-B IPv6 LLA                                      [FAIL]

#######################################################
HINT: Fails since VRF device does not support linklocal or multicast

COMMAND: ip netns exec ns-A /bin/ping6 -c1 -w1 ff02::1%red
ping: sendmsg: Network is unreachable
PING ff02::1%red(ff02::1%red) 56 data bytes

--- ff02::1%red ping statistics ---
1 packets transmitted, 0 received, 100% packet loss, time 0ms

TEST: ping out, VRF bind - multicast IP                                       [FAIL]

#######################################################

 best regards,

________________________________________
From: David Ahern <dsahern@...il.com>
Sent: Wednesday, December 8, 2021 11:20 AM
To: Jakub Kicinski; lizhijian@...itsu.com
Cc: Zhou, Jie2X; davem@...emloft.net; shuah@...nel.org; netdev@...r.kernel.org; linux-kselftest@...r.kernel.org; linux-kernel@...r.kernel.org; Li, Philip; lkp; Ma, XinjianX; Li, ZhijianX
Subject: Re: selftests/net/fcnal-test.sh: ipv6_ping test failed

On 12/7/21 8:58 AM, Jakub Kicinski wrote:
> Adding David and Zhijian.
>
> On Tue, 7 Dec 2021 07:07:40 +0000 Zhou, Jie2X wrote:
>> hi,
>>
>>   I test ipv6_ping by "./fcnal-test.sh -v -t ipv6_ping".
>>   There are two tests failed.
>>
>>    TEST: ping out, VRF bind - ns-B IPv6 LLA                                      [FAIL]
>>    TEST: ping out, VRF bind - multicast IP                                       [FAIL]
>>
>>    While in fcnal-test.sh the expected command result is 2, the result is 1, so the test failed.
>>    ipv6_ping_vrf()
>>    {
>>     ......
>>         for a in ${NSB_LINKIP6}%${VRF} ${MCAST}%${VRF}
>>         do
>>                 log_start
>>                 show_hint "Fails since VRF device does not support linklocal or multicast"
>>                 run_cmd ${ping6} -c1 -w1 ${a}
>>                 log_test_addr ${a} $? 2 "ping out, VRF bind"
>>         done
>>
>>     The ipv6_ping test output is attached.
>>     Did I set something wrong result that these tests failed?
>>
>> best regards,

ping6 is failing as it should. Can you send a patch to change the
expected rc from 2 to 1?