linux-kernel - Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ee6n18im.wl-maz@kernel.org>
Date:   Wed, 08 Dec 2021 14:22:25 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Alexandre TORGUE <alexandre.torgue@...s.st.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/3] irqchip/stm32-exti: add STM32MP13 support

Hi Alexandre,

On Wed, 08 Dec 2021 13:58:46 +0000,
Alexandre TORGUE <alexandre.torgue@...s.st.com> wrote:
> 
> > Why does the driver need to carry these tables? This sort of
> > information should really come from DT, instead of being hardcoded in
> > the driver and bloating it for no reason. This all has a funny taste
> > of the board files we used to have pre-DT.
> > 
> 
> There are absolutely no reason to have it in driver. Honestly It has
> been done in this way to have minimal changes adding this new SoC
> support (and it's not smart, I agree).
> 
> I think it is better to abandon this series. I will create a new one
> which moves mapping table for MP15 and adds MP13 support to.

I'm afraid you'll have to keep the in-kernel table for MP15, since the
driver needs to work with old DTs. For new SoCs (such as MP13), moving
the table into DT would be good.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.