linux-kernel - RE: [PATCH] scsi: pm8001: Fix phys_to_virt() usage on dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB51120361EB6F6931CCE023D6EC709@PH0PR11MB5112.namprd11.prod.outlook.com>
Date:   Thu, 9 Dec 2021 12:04:49 +0000
From:   <Ajish.Koshy@...rochip.com>
To:     <john.garry@...wei.com>
CC:     <jinpu.wang@...ud.ionos.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <Viswas.G@...rochip.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <damien.lemoal@...nsource.wdc.com>, <Niklas.Cassel@....com>,
        <Vasanthalakshmi.Tharmarajan@...rochip.com>
Subject: RE: [PATCH] scsi: pm8001: Fix phys_to_virt() usage on dma_addr_t

Hi John,

Was testing the patch on arm server. Didn't see crash there but observing timeouts and error 
handling getting triggered for drives. But the same code works fine on x86.

At your end do you still face similar situation on arm server ?

Thanks,
Ajish

-----Original Message-----
From: John Garry <john.garry@...wei.com> 
Sent: Tuesday, December 7, 2021 07:24 PM
To: Ajish Koshy - I30923 <Ajish.Koshy@...rochip.com>
Cc: jinpu.wang@...ud.ionos.com; jejb@...ux.ibm.com; martin.petersen@...cle.com; Viswas G - I30667 <Viswas.G@...rochip.com>; linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; damien.lemoal@...nsource.wdc.com; Niklas.Cassel@....com; Vasanthalakshmi Tharmarajan - I30664 <Vasanthalakshmi.Tharmarajan@...rochip.com>
Subject: Re: [PATCH] scsi: pm8001: Fix phys_to_virt() usage on dma_addr_t

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On 07/12/2021 10:36, Ajish.Koshy@...rochip.com wrote:
> Well I could see this kernel panic [  126.843958] RIP: 0010:pm80xx_chip_smp_req+0x1d6/0x2e0 [pm80xx] with respect to existing driver on my current system x86 64bit after enabling the following 2 kernel boot arguments:
> -intel_iommu=on
> -iommu.passthrough=0
>
OK, so it seems that it was the kernel which was just not enabling the IOMMU previously, which would be consistent with what Niklas mentioned.

Anyway, please supply reviewed-by and/or tested-by tags so that the SCSI maintainers can pick it up.

I suppose that we should also have:

Fixes: f5860992db55 ("[SCSI] pm80xx: Added SPCv/ve specific hardware functionalities and relevant changes in common files")

Thanks for testing,
John