linux-kernel - Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mtl8qifu.fsf@meer.lwn.net>
Date:   Fri, 10 Dec 2021 14:05:41 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Shuah Khan <skhan@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        David Gow <davidgow@...gle.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>, Tim.Bird@...y.com,
        shuah@...nel.org, rmr167@...il.com, guillaume.tucker@...labora.com,
        dlatypov@...gle.com, kernelci@...ups.io,
        kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification

Shuah Khan <skhan@...uxfoundation.org> writes:

> On 12/7/21 3:02 PM, Kees Cook wrote:
>> On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote:
>>> From: Rae Moar <rmoar@...gle.com>
>>>
>>> It does not make any significant additions or changes other than those
>>> already in use in the kernel: additional features can be added as they
>>> become necessary and used.
>>>
>>> [1]: https://testanything.org/tap-version-13-specification.html
>>>
>>> Signed-off-by: Rae Moar <rmoar@...gle.com>
>>> Co-developed-by: David Gow <davidgow@...gle.com>
>>> Signed-off-by: David Gow <davidgow@...gle.com>
>> 
>> I like it! Thank you so much for suffering through my earlier reviews.
>> :)
>> 
>> The only concern I have is wonder what'll be needed to kselftest to
>> deal with indentation changes. As long as this can be implemented
>> without a subtest knowing it is a subtest, we're good.
>> 
>
> A lot of this TAP output is in the wrappers - hopefully it will be okay.
> Fingers crossed. :)
>
>> Reviewed-by: Kees Cook <keescook@...omium.org>
>> 
>
> Looks good to me as well. Thanks for doing this work.
>
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

Would you like me to take this through the docs tree, or do you have
other plans for merging?

Thanks,

jon