linux-kernel - Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47a32b46-2c9b-2f27-4100-af69b34f2df5@nvidia.com>
Date:   Tue, 14 Dec 2021 07:23:50 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Bart Van Assche <bvanassche@....org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Eric Biggers <ebiggers@...nel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs

On 12/13/21 9:04 PM, Bart Van Assche wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 12/11/21 02:50, Greg Kroah-Hartman wrote:
>> On Fri, Dec 10, 2021 at 09:29:41AM -0800, Bart Van Assche wrote:
>>> (b) No other block layer sysfs attribute follows this encoding scheme.
>>
>> Then follow what they do.  Do they have multiple values in a single
>> file?  If so, they are broken and we should change that.
> 
> Hi Greg,
> 
> The only other block layer sysfs attribute I know of that reports
> multiple values is the queue/scheduler attribute. Here is an example of
> the output that can be produced by reading that attribute:
> 
> # cat /sys/block/sda/queue/scheduler
> [mq-deadline] kyber bfq none
> 
> I don't think that changing the behavior of that attribute is an option
> because that would break existing user space software, e.g. the
> https://github.com/osandov/blktests/ test suite.
> 
> Thanks,
> 
> Bart.

If possible please avoid changing these values.