linux-kernel - Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbhH9z/hVg+RsWhL@kroah.com>
Date:   Tue, 14 Dec 2021 08:29:59 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     Eric Biggers <ebiggers@...nel.org>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-mmc@...r.kernel.org,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs

On Mon, Dec 13, 2021 at 09:04:29PM -0800, Bart Van Assche wrote:
> On 12/11/21 02:50, Greg Kroah-Hartman wrote:
> > On Fri, Dec 10, 2021 at 09:29:41AM -0800, Bart Van Assche wrote:
> > > (b) No other block layer sysfs attribute follows this encoding scheme.
> > 
> > Then follow what they do.  Do they have multiple values in a single
> > file?  If so, they are broken and we should change that.
> 
> Hi Greg,
> 
> The only other block layer sysfs attribute I know of that reports multiple
> values is the queue/scheduler attribute. Here is an example of the output
> that can be produced by reading that attribute:
> 
> # cat /sys/block/sda/queue/scheduler
> [mq-deadline] kyber bfq none

That's fine, there is no problem there.

That output is the "correct" way to show a list of options and the one
that is currently selected in a sysfs file as I thought I said earlier
in this thread.

> I don't think that changing the behavior of that attribute is an option
> because that would break existing user space software, e.g. the
> https://github.com/osandov/blktests/ test suite.

Very true, do not change this file format.

thanks,

greg k-h