linux-kernel - Re: [PATCH -next] block/wbt: fix negative inflight counter when remove scsi device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbhQp9H6Z08izS+T@infradead.org>
Date:   Tue, 14 Dec 2021 00:07:03 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Laibin Qiu <qiulaibin@...wei.com>, axboe@...nel.dk,
        yi.zhang@...wei.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] block/wbt: fix negative inflight counter when
 remove scsi device

On Tue, Dec 14, 2021 at 09:13:10AM +0800, Ming Lei wrote:
> > Wouldn't it make more sense to simply not call wbt_enable_default from
> > elv_unregister_queue?
> 
> wbt_disable_default() is called in bfq_init_root_group(), so wbt_enable_default

s/bfq_init_root_group/bfq_init_queue/

But yes, that sounds like an even better idea.  Or maybe even an
elevator feature flag.