linux-kernel - Re: [PATCH] KVM: PPC: Book3S HV P9: Use kvm_arch_vcpu_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6D5BB54E-442E-4097-932B-7E0AC949D47C@linux.vnet.ibm.com>
Date:   Tue, 14 Dec 2021 13:37:09 +0530
From:   Sachin Sant <sachinp@...ux.vnet.ibm.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Nicholas Piggin <npiggin@...il.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH] KVM: PPC: Book3S HV P9: Use kvm_arch_vcpu_get_wait() to
 get rcuwait object



> On 13-Dec-2021, at 11:15 PM, Sean Christopherson <seanjc@...gle.com> wrote:
> 
> Use kvm_arch_vcpu_get_wait() to get a vCPU's rcuwait object instead of
> using vcpu->wait directly in kvmhv_run_single_vcpu().  Functionally, this
> is a nop as vcpu->arch.waitp is guaranteed to point at vcpu->wait.  But
> that is not obvious at first glance, and a future change coming in via
> the KVM tree, commit 510958e99721 ("KVM: Force PPC to define its own
> rcuwait object"), will hide vcpu->wait from architectures that define
> __KVM_HAVE_ARCH_WQP to prevent generic KVM from attepting to wake a vCPU
> with the wrong rcuwait object.
> 
> Reported-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> —
> 
Thanks for the patch.

Tested-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>