linux-kernel - [robh:for-kernelci 1/9] drivers/tty/serial/lantiq.c:732 fetch_irq_lantiq() warn: unsigned 'ltq_port->tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 14 Dec 2021 20:00:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Rob Herring <robh@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [robh:for-kernelci 1/9] drivers/tty/serial/lantiq.c:732
 fetch_irq_lantiq() warn: unsigned 'ltq_port->tx_irq' is never less than
 zero.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-kernelci
head:   0e59c9b64d3363b98201fc040101f8ff62c7eafb
commit: e12887def507246bafed1c9b1b7f4f03ab225da5 [1/9] serial: lantiq: Remove usage of of_irq_to_resource_table()/of_irq_get()
config: i386-randconfig-m021-20211210 (https://download.01.org/0day-ci/archive/20211214/202112141920.cCz4wG5n-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
drivers/tty/serial/lantiq.c:732 fetch_irq_lantiq() warn: unsigned 'ltq_port->tx_irq' is never less than zero.
drivers/tty/serial/lantiq.c:735 fetch_irq_lantiq() warn: unsigned 'ltq_port->rx_irq' is never less than zero.
drivers/tty/serial/lantiq.c:738 fetch_irq_lantiq() warn: unsigned 'ltq_port->err_irq' is never less than zero.

vim +732 drivers/tty/serial/lantiq.c

   725	
   726	static int fetch_irq_lantiq(struct device *dev, struct ltq_uart_port *ltq_port)
   727	{
   728		struct uart_port *port = &ltq_port->port;
   729		struct platform_device *pdev = to_platform_device(dev);
   730	
   731		ltq_port->tx_irq = platform_get_irq(pdev, 0);
 > 732		if (ltq_port->tx_irq < 0)
   733			return ltq_port->tx_irq;
   734		ltq_port->rx_irq = platform_get_irq(pdev, 1);
 > 735		if (ltq_port->rx_irq < 0)
   736			return ltq_port->rx_irq;
   737		ltq_port->err_irq = platform_get_irq(pdev, 2);
 > 738		if (ltq_port->err_irq < 0)
   739			return ltq_port->err_irq;
   740	
   741		port->irq = ltq_port->tx_irq;
   742	
   743		return 0;
   744	}
   745	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org