linux-kernel - Re: [PATCH] virtio: fix spelling error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEv3unSNMvj78e_Cdynz6zaTz-BZ5e20wF3dMURODqe1Hg@mail.gmail.com>
Date:   Thu, 16 Dec 2021 11:17:39 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     zhuxinran <zhuran@...l.ustc.edu.cn>
Cc:     ericvh@...il.com, lucho@...kov.net, asmadeus@...ewreck.org,
        davem <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
        v9fs-developer@...ts.sourceforge.net,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio: fix spelling error

On Thu, Dec 16, 2021 at 11:09 AM zhuxinran <zhuran@...l.ustc.edu.cn> wrote:
>
> start my first kernel patch commit
>

Patch looks good but this is not a good change log.

It should be something like "Fix typo in the comment for p9_virtio_create()"

Thanks

> Signed-off-by: zhuxinran <zhuran@...l.ustc.edu.cn>
> ---
>  net/9p/trans_virtio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index bd5a89c4960d..f7dc561ca516 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -648,7 +648,7 @@ static int p9_virtio_probe(struct virtio_device *vdev)
>   * @args: args passed from sys_mount() for per-transport options (unused)
>   *
>   * This sets up a transport channel for 9p communication.  Right now
> - * we only match the first available channel, but eventually we couldlook up
> + * we only match the first available channel, but eventually we could look up
>   * alternate channels by matching devname versus a virtio_config entry.
>   * We use a simple reference count mechanism to ensure that only a single
>   * mount has a channel open at a time.
> --
> 2.33.1
>
>