linux-kernel - Re: [PATCH] virtio: fix spelling error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbqwDPjapugTakhZ@codewreck.org>
Date:   Thu, 16 Dec 2021 12:18:36 +0900
From:   asmadeus@...ewreck.org
To:     zhuxinran <zhuran@...l.ustc.edu.cn>
Cc:     ericvh@...il.com, lucho@...kov.net, davem@...emloft.net,
        kuba@...nel.org, v9fs-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio: fix spelling error


Thanks for the patch.

A few comments below:
zhuxinran wrote on Thu, Dec 16, 2021 at 11:08:36AM +0800:
> Subject: virtio: fix spelling error

"virtio" is much more than this.
Have a look at previous commit messages for this file, something like
'9p/trans_virtio' would make a better component name.

(`git log net/9p/trans_virtio.c` to get git history for a single file)

> start my first kernel patch commit

This is not particularly useful for someone reading the git log, I'd
just remove this line.


I can do both changes on my end, but since you're learning it can also
be a good time to also see how to send a v2 (setting subject as [PATCH
v2], sending patch with in-reply-to)

I don't really mind either way, please let me know if you won't resend.

-- 
Dominique